Skip to content

Conversation

jonastheis
Copy link
Contributor

@jonastheis jonastheis commented Sep 1, 2025

This PR adds a rollup node RPC namespace and two specific functions to enable/disable sequencing via this new RPC namespace. Based on examples from https://github.com/scroll-tech/reth/blob/scroll/examples/node-custom-rpc/src/main.rs and https://github.com/paritytech/jsonrpsee/blob/master/examples/examples/proc_macro.rs.

Closes #286

@jonastheis jonastheis marked this pull request as ready for review September 2, 2025 05:09
@jonastheis jonastheis requested a review from frisitano September 2, 2025 05:09
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shall we add an e2e test that invokes these rpc methods and ensures expected behaviour?

@jonastheis jonastheis requested a review from frisitano September 3, 2025 00:00
frisitano
frisitano previously approved these changes Sep 3, 2025
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments in line.

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonastheis jonastheis merged commit 12a3246 into main Sep 3, 2025
13 checks passed
@jonastheis jonastheis deleted the feat/automatic-sequencing-admin-rpc branch September 3, 2025 05:41
@frisitano frisitano mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RPC] Sequencer management rpc
2 participants